RFR: 8307653: Adjust delay time and gc log argument in TestAbortOnVMOperationTimeout [v2]

Daniel D. Daugherty dcubed at openjdk.org
Wed May 10 16:28:21 UTC 2023


On Tue, 9 May 2023 09:04:14 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch increases the delay time of the test `TestAbortOnVMOperationTimeout` 
>> so that it can pass on the low performance devices (such as my local riscv64 dev board).
>> 
>> And I adjust the gc log options to get more gc log message which is useful to
>> inspect the issue [JDK-8296819](https://bugs.openjdk.org/browse/JDK-8296819).
>> 
>> Thanks for the review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary loop. Add bug id. Adjust the action time out.

Changes requested by dcubed (Reviewer).

test/hotspot/jtreg/runtime/Safepoint/TestAbortOnVMOperationTimeout.java line 54:

> 52:         }
> 53: 
> 54:         // These should definitely pass: more than 3 minutes is enough for Serial to act.

"These" is no longer accurate since this has been changed to test a single value.

test/hotspot/jtreg/runtime/Safepoint/TestAbortOnVMOperationTimeout.java line 56:

> 54:         // These should definitely pass: more than 3 minutes is enough for Serial to act.
> 55:         // The values are deliberately non-round to trip off periodic task granularity.
> 56:         testWith(183423, true);

"The values are ..." is no longer accurate since this has been changed to test a single value.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13878#pullrequestreview-1421003090
PR Review Comment: https://git.openjdk.org/jdk/pull/13878#discussion_r1190145346
PR Review Comment: https://git.openjdk.org/jdk/pull/13878#discussion_r1190146136


More information about the hotspot-runtime-dev mailing list