RFR: 8307653: Adjust delay time and gc log argument in TestAbortOnVMOperationTimeout [v2]

Guoxiong Li gli at openjdk.org
Thu May 11 01:40:42 UTC 2023


On Wed, 10 May 2023 16:23:44 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary loop. Add bug id. Adjust the action time out.
>
> test/hotspot/jtreg/runtime/Safepoint/TestAbortOnVMOperationTimeout.java line 54:
> 
>> 52:         }
>> 53: 
>> 54:         // These should definitely pass: more than 3 minutes is enough for Serial to act.
> 
> "These" is no longer accurate since this has been changed to test a single value.

Fixed.

> test/hotspot/jtreg/runtime/Safepoint/TestAbortOnVMOperationTimeout.java line 56:
> 
>> 54:         // These should definitely pass: more than 3 minutes is enough for Serial to act.
>> 55:         // The values are deliberately non-round to trip off periodic task granularity.
>> 56:         testWith(183423, true);
> 
> "The values are ..." is no longer accurate since this has been changed to test a single value.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13878#discussion_r1190547527
PR Review Comment: https://git.openjdk.org/jdk/pull/13878#discussion_r1190547652


More information about the hotspot-runtime-dev mailing list