Integrated: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
Axel Boldt-Christmas
aboldtch at openjdk.org
Tue May 23 15:39:30 UTC 2023
On Tue, 16 May 2023 08:06:15 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> jdk.test.lib.compiler.InMemoryJavaCompiler.compile(String className, CharSequence sourceCode, String... options) creates a JavaFileManager but fails to close it after the CompilationTask is completed, leaving the file descriptors open until reference processing kicks in.
>
> Graph below shows number of open file descriptors before and after this patch for a program which compiles dummy classes in a loop.
> <img width="1116" alt="Before and after" src="https://github.com/openjdk/jdk/assets/1139284/1ecfb32a-735b-4765-bcca-81f67a4c9816">
>
> Testing: GHA and Oracle CI tier1-3. Tests using jdk.test.lib.compiler.InMemoryJavaCompiler also tested locally.
This pull request has now been integrated.
Changeset: e9320f31
Author: Axel Boldt-Christmas <aboldtch at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e9320f31dcc4ff5197e8c3bca504a7d5c1a9035e
Stats: 33 lines in 1 file changed: 15 ins; 15 del; 3 mod
8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
Reviewed-by: lmesnik, stefank, jlahoda
-------------
PR: https://git.openjdk.org/jdk/pull/14001
More information about the hotspot-runtime-dev
mailing list