RFR: 8263464: NMT: assert in gtest os.release_multi_mappings_vm [v7]

Gerard Ziemski gziemski at openjdk.org
Thu May 25 15:04:09 UTC 2023


On Wed, 24 May 2023 17:49:23 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> src/hotspot/share/services/virtualMemoryTracker.cpp line 528:
>> 
>>> 526:   }
>>> 527: 
>>> 528:   if (size <= reserved_rgn->size() && reserved_rgn->contain_region(addr, size)) {
>> 
>> A region which contains another must necessarily have at least the size of the contained region, therefore the size check is unnecessary.
>
> Ah, I see now, you are correct. I will fix it.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13813#discussion_r1205650212


More information about the hotspot-runtime-dev mailing list