RFR: 8319137: SetNameAtExit fails with "assert(!is_null()) failed: Must be created"

[Stefan Karlsson]

On Mon, 20 Nov 2023 14:44:08 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Please review the following fix which moves the release of the _object WeakHandle back to the ObjectMonitor dtor. Releasing it earlier as we do today introduces a race which can lead to crashes. Tested running tiers123 in mach5.
> 
> Thanks,
> Patricio

Marked as reviewed by stefank (Reviewer).

src/hotspot/share/runtime/objectMonitor.cpp line 279:

> 277: 
> 278: ObjectMonitor::~ObjectMonitor() {
> 279:   release_object();

I think it would be nice to move the implementation of release_object over to the .cpp file. Alternatively, inline the implementation straight into the destructor. If you don't want to do it in this PR I can do it as a separate change.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16738#pullrequestreview-1740112392
PR Review Comment: https://git.openjdk.org/jdk/pull/16738#discussion_r1399380827