RFR: 8319137: SetNameAtExit fails with "assert(!is_null()) failed: Must be created" [v2]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Mon Nov 20 16:36:09 UTC 2023
On Mon, 20 Nov 2023 15:34:55 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> inline release in ~ObjectMonitor()
>
> src/hotspot/share/runtime/objectMonitor.cpp line 279:
>
>> 277:
>> 278: ObjectMonitor::~ObjectMonitor() {
>> 279: release_object();
>
> I think it would be nice to move the implementation of release_object over to the .cpp file. Alternatively, inline the implementation straight into the destructor. If you don't want to do it in this PR I can do it as a separate change.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16738#discussion_r1399464692
More information about the hotspot-runtime-dev
mailing list