RFR: JDK-8319307: DCmds should not assert on truncation and should report truncation [v2]

[Thomas Stuefe]

On Tue, 28 Nov 2023 06:20:25 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8319307-DCmds-should-not-assert-on-truncation-and-should-report-truncation
>>  - fix mac builds
>>  - JDK-8319307-DCmds-should-not-assert-on-truncation-and-should-report-truncation
>
> src/hotspot/os/aix/attachListener_aix.cpp line 457:
> 
>> 455:       char msg [] = "\n(truncated)\n";
>> 456:       AixAttachListener::write_fully(this->socket(), msg, strlen(msg));
>> 457:     }
> 
> Isn't this happening too late? The st content has already been truncated and we have written the "final" message to the socket for the client to read, and then we try to send a follow-up message that the original was truncated. ???

No, that works. I have of course tested it (not on AIX, though). Jcmd prints everything it gets until the socket closes, no matter how many times hotspot called write().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16474#discussion_r1407288299