RFR: JDK-8319307: DCmds should not assert on truncation and should report truncation [v2]

[David Holmes]

On Tue, 28 Nov 2023 06:34:33 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/os/aix/attachListener_aix.cpp line 457:
>> 
>>> 455:       char msg [] = "\n(truncated)\n";
>>> 456:       AixAttachListener::write_fully(this->socket(), msg, strlen(msg));
>>> 457:     }
>> 
>> Isn't this happening too late? The st content has already been truncated and we have written the "final" message to the socket for the client to read, and then we try to send a follow-up message that the original was truncated. ???
>
> No, that works. I have of course tested it (not on AIX, though). Jcmd prints everything it gets until the socket closes, no matter how many times hotspot called write().

Okay. Do we not then have to check the rc of the first `write_fully` and only do this follow up write if `rc == 0`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16474#discussion_r1407293367