RFR: 8315362: NMT: summary diff reports threads count incorrectly [v2]

[Johan Sjölen]

On Mon, 2 Oct 2023 09:19:54 GMT, Evgeny Ignatenko <duke at openjdk.org> wrote:

>> 8315362: NMT: summary diff reports threads count incorrectly
>
> Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Hi,

Thank you for this PR. This fix looks good to me, it's unfortunate that we have this `track_as_vm` condition spread throughout the code but we'll leave fixing that for a future PR.

This is a Hotspot change, so you'll require 2 reviews (one from a Reviewer, which I am). After you've received to approvals I'll sponsor your change and you can merge it.

test/hotspot/jtreg/runtime/NMT/SummaryDiffThreadCount.java line 31:

> 29:  * @modules java.base/jdk.internal.misc
> 30:  *          java.management
> 31:  * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:NativeMemoryTracking=summary SummaryDiffThreadCount

Why is `-Xbootclasspath/a:.` needed?

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15490#pullrequestreview-1654689224
PR Review Comment: https://git.openjdk.org/jdk/pull/15490#discussion_r1343748759