RFR: 8315818: vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java fails on libgraal [v2]

[Tom Rodriguez]

On Thu, 7 Sep 2023 11:01:16 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Instead of eagerly initializing JVMCI for `-Xcomp`, this defers JVMCI compilations until JVMCI is initializable. In the case of libgraal, no compilations are deferred since libgraal is always initializable. For jargraal, it still has to wait until the VM has reached a certain initialization phase so as to avoid deadlocks bewteen the main thread and a compiler thread.
>> 
>> This allows tests such as `vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java` to succeed on libgraal, even when there is insufficient virtual memory to mmap libgraal. Failing to initialize libgraal in that scenario now results in a bailout instead of exiting the VM.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instead of eagerly initializing JVMCI for -Xcomp, defer JVMCI compilations until JVMCI is initializable

src/hotspot/share/runtime/threads.cpp line 748:

> 746: #if INCLUDE_JVMCI
> 747:   if (force_JVMCI_initialization) {
> 748:     JVMCI::initialize_compiler(CHECK_JNI_ERR);

Does anything bad happen if force_JVMCI_initialization is true and we end up initializing the compiler from the compile broker thread instead?  I guess that would be adding Xcomp to the the other flags that force initialization.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15602#discussion_r1318992721