RFR: 8315818: vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java fails on libgraal [v2]

[Doug Simon]

On Thu, 7 Sep 2023 18:45:47 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instead of eagerly initializing JVMCI for -Xcomp, defer JVMCI compilations until JVMCI is initializable
>
> src/hotspot/share/runtime/threads.cpp line 748:
> 
>> 746: #if INCLUDE_JVMCI
>> 747:   if (force_JVMCI_initialization) {
>> 748:     JVMCI::initialize_compiler(CHECK_JNI_ERR);
> 
> Does anything bad happen if force_JVMCI_initialization is true and we end up initializing the compiler from the compile broker thread instead?  I guess that would be adding Xcomp to the the other flags that force initialization.

Both `JVMCIPrintProperties` and `JVMCILibDumpJNIConfig` explicitly do the equivalent of `System.exit()` once they've performed their task so I don't think it matters which thread triggers the task. I don't think it will cause any problems for `EagerJVMCI` either. In fact, I don't think we really need `EagerJVMCI` any more as it's only purpose was to make `JVMCIPrintProperties` guaranteed to do something.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15602#discussion_r1319005590