RFR: 8315795: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java fails after JDK-8305507 [v2]

Patricio Chilano Mateo pchilanomate at openjdk.org
Thu Sep 7 19:15:17 UTC 2023


> Please review this small fix to test TestAbortVMOnSafepointTimeout.java. With the current value of AbortVMOnSafepointTimeoutDelay we get cases where the spawned child VM exits with a safepoint timeout but without the main thread being able to print the PRE_STALL_TEXT text. I added a more detailed analysis in the bug comments.
> To fix it I increased the value of AbortVMOnSafepointTimeoutDelay to be about twice as much as the longest time it could take to print the PRE_STALL_TEXT based on the measurements I have done in the failing Windows machines.
> Without the fix I can reproduce the issue in about 10% of the runs running tier1_runtime. With the fix I run ~400 runs of tier1_runtime without failures.
> 
> Thanks,
> Patricio

Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:

  address Dan's comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15622/files
  - new: https://git.openjdk.org/jdk/pull/15622/files/340175b1..fcb97d5a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15622&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15622&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/15622.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15622/head:pull/15622

PR: https://git.openjdk.org/jdk/pull/15622


More information about the hotspot-runtime-dev mailing list