RFR: 8315795: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java fails after JDK-8305507 [v2]
Daniel D. Daugherty
dcubed at openjdk.org
Thu Sep 7 20:07:41 UTC 2023
On Thu, 7 Sep 2023 19:15:17 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> Please review this small fix to test TestAbortVMOnSafepointTimeout.java. With the current value of AbortVMOnSafepointTimeoutDelay we get cases where the spawned child VM exits with a safepoint timeout but without the main thread being able to print the PRE_STALL_TEXT text. I added a more detailed analysis in the bug comments.
>> To fix it I increased the value of AbortVMOnSafepointTimeoutDelay to be about twice as much as the longest time it could take to print the PRE_STALL_TEXT based on the measurements I have done in the failing Windows machines.
>> Without the fix I can reproduce the issue in about 10% of the runs running tier1_runtime. With the fix I run ~400 runs of tier1_runtime without failures.
>>
>> Thanks,
>> Patricio
>
> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>
> address Dan's comments
Thumbs up and this fix is trivial.
-------------
Marked as reviewed by dcubed (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15622#pullrequestreview-1616164295
More information about the hotspot-runtime-dev
mailing list