RFR: 8314832: Few runtime/os tests ignore vm flags

David Holmes dholmes at openjdk.org
Mon Sep 11 07:44:37 UTC 2023


On Fri, 8 Sep 2023 22:31:10 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

> 8314832: Few runtime/os tests ignore vm flags

Changes requested by dholmes (Reviewer).

test/hotspot/jtreg/runtime/os/THPsInThreadStackPreventionTest.java line 1:

> 1: /*

I think this test should also be marked vm.flagless. Running with additional flags, especially something like -Xcomp, could have an effect on the RSS usage that the test is trying to measure. Other flags really have no bearing on what is being tested here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15647#pullrequestreview-1619322747
PR Review Comment: https://git.openjdk.org/jdk/pull/15647#discussion_r1321119801


More information about the hotspot-runtime-dev mailing list