RFR: 8314832: Few runtime/os tests ignore vm flags

Mikhailo Seledtsov mseledtsov at openjdk.org
Mon Sep 11 16:41:39 UTC 2023


On Mon, 11 Sep 2023 07:41:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> 8314832: Few runtime/os tests ignore vm flags
>
> test/hotspot/jtreg/runtime/os/THPsInThreadStackPreventionTest.java line 1:
> 
>> 1: /*
> 
> I think this test should also be marked vm.flagless. Running with additional flags, especially something like -Xcomp, could have an effect on the RSS usage that the test is trying to measure. Other flags really have no bearing on what is being tested here.

David, thank you for advice. I will update the test to mark it "flagless".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15647#discussion_r1321811897


More information about the hotspot-runtime-dev mailing list