RFR: 8314830: runtime/ErrorHandling/ tests ignore external VM flags

[David Holmes]

On Fri, 15 Sep 2023 17:58:43 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

> 8314830: runtime/ErrorHandling/ tests ignore external VM flags

I agree with the reasoning here, except for VeryEarlyAssert.

Thanks.

test/hotspot/jtreg/runtime/ErrorHandling/VeryEarlyAssertTest.java line 52:

> 50: 
> 51: 
> 52:     ProcessBuilder pb = ProcessTools.createTestJvm("-version");

I don't think this is necessary. IIUC this test triggers an assertion failure during the static initialization that occurs in debug.o which will happen when libjvm is loaded, well before any argument processing could occur, or have any impact.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15767#pullrequestreview-1630197266
PR Review Comment: https://git.openjdk.org/jdk/pull/15767#discussion_r1328193835