RFR: 8314830: runtime/ErrorHandling/ tests ignore external VM flags [v2]

Mikhailo Seledtsov mseledtsov at openjdk.org
Mon Sep 18 23:39:11 UTC 2023


On Mon, 18 Sep 2023 01:53:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing review feedback
>
> test/hotspot/jtreg/runtime/ErrorHandling/VeryEarlyAssertTest.java line 52:
> 
>> 50: 
>> 51: 
>> 52:     ProcessBuilder pb = ProcessTools.createTestJvm("-version");
> 
> I don't think this is necessary. IIUC this test triggers an assertion failure during the static initialization that occurs in debug.o which will happen when libjvm is loaded, well before any argument processing could occur, or have any impact.

David, thank you for providing the details. I agree, and have updated the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15767#discussion_r1329387157


More information about the hotspot-runtime-dev mailing list