RFR: 8317132: Prepare HotSpot for permissive-

[David Holmes]

On Thu, 28 Sep 2023 03:22:30 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all of the fixes required for HotSpot to compile under the stricter mode activated when the permissive- flag is passed

Can you add information to the bug report about the actual errors caused by these coding constructs please.

Thanks

src/hotspot/os/windows/symbolengine.cpp line 114:

> 112:       _capacity = (int)(sizeof(_fallback_buffer) / sizeof(T));
> 113:     }
> 114:     _p[0] = 0;

I seem to recall this being discussed in the past and it was suggested to do what is done previously and use:

_p[0] = (T) '\0';

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15955#pullrequestreview-1647862834
PR Review Comment: https://git.openjdk.org/jdk/pull/15955#discussion_r1339505353