RFR: 8317132: Prepare HotSpot for permissive-

David Holmes dholmes at openjdk.org
Thu Sep 28 04:41:24 UTC 2023


On Thu, 28 Sep 2023 04:21:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all of the fixes required for HotSpot to compile under the stricter mode activated when the permissive- flag is passed
>
> src/hotspot/os/windows/symbolengine.cpp line 114:
> 
>> 112:       _capacity = (int)(sizeof(_fallback_buffer) / sizeof(T));
>> 113:     }
>> 114:     _p[0] = 0;
> 
> I seem to recall this being discussed in the past and it was suggested to do what is done previously and use:
> 
> _p[0] = (T) '\0';

Ah never mind. A link to:
https://github.com/openjdk/jdk/pull/15096/
would have been a useful reminder.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15955#discussion_r1339516670


More information about the hotspot-runtime-dev mailing list