RFR: 8317132: Prepare HotSpot for permissive-
Julian Waters
jwaters at openjdk.org
Sat Sep 30 06:01:48 UTC 2023
On Fri, 29 Sep 2023 15:11:02 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> This decision was based on a review comment in https://github.com/openjdk/jdk/pull/15096, which preferred keeping InterceptOSException without the negation. Perhaps I'll wait until Thomas sees this Pull Request
>
> Okay. If an early bailout is desirable, I suggest instead putting everything in the `else` block into a helper method, and then have `if (InterceptOSException) return;` at the start. `topLevelUnhandledExceptionFilter` can then do:
>
>
> helper(exceptionInfo); // or whatever name is chosen
> return previousUnhandledExceptionFilter ? previousUnhandledExceptionFilter(exceptionInfo) : EXCEPTION_CONTINUE_SEARCH;
Hmm, creating an entire method exclusively for this seems a bit excessive, what if I just surrounded the else block with a scope and kept everything else the same? The issue is goto jumping across the locals of this method after all, which a scope coould solve
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15955#discussion_r1341915671
More information about the hotspot-runtime-dev
mailing list