RFR: 8317132: Prepare HotSpot for permissive-

Jorn Vernee jvernee at openjdk.org
Sat Sep 30 13:10:45 UTC 2023


On Sat, 30 Sep 2023 05:58:15 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Okay. If an early bailout is desirable, I suggest instead putting everything in the `else` block into a helper method, and then have `if (InterceptOSException) return;` at the start. `topLevelUnhandledExceptionFilter` can then do:
>> 
>> 
>> helper(exceptionInfo); // or whatever name is chosen
>> return previousUnhandledExceptionFilter ? previousUnhandledExceptionFilter(exceptionInfo) : EXCEPTION_CONTINUE_SEARCH;
>
> Hmm, creating an entire method exclusively for this seems a bit excessive, what if I just surrounded the else block with a scope and kept everything else the same? The issue is goto jumping across the locals of this method after all, which a scope coould solve

That seems fine

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15955#discussion_r1341960335


More information about the hotspot-runtime-dev mailing list