RFR: 8323807: Async UL: Add a stalling mode to async UL [v2]

Johan Sjölen jsjolen at openjdk.org
Tue Apr 2 10:39:02 UTC 2024


On Tue, 2 Apr 2024 07:56:28 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/share/logging/circularStringBuffer.cpp line 92:
>> 
>>> 90:     head(0) {}
>>> 91: 
>>> 92: size_t CircularStringBuffer::used() {
>> 
>> Is this API being drawn from some pre-existing code for circular buffers? I find the used/unused terminology a little unusual.
>
> The head/tail terminology is straight from Linux kernel, but used/unused is of my own making AFAIK. What's a better pair of names? Allocated/unallocated?

I went for `available_bytes` and `allocated_bytes`. Mentioning that it is bytes explicitly does lend some clarity to the code, imho.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17757#discussion_r1547594249


More information about the hotspot-runtime-dev mailing list