RFR: 8327410: Add hostname option for UL file names [v4]

[Fredrik Bredberg]

On Fri, 8 Mar 2024 06:40:05 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Hi Fredrik,
>> 
>> I'm sorry but I think this needs some changes :-). This PR saves the hostname regardless if the hostname is requrested as part of the log filename or not. This means that the hostname is present in the heap of the JVM process, but I believe that the hostname should be considered confidential data. We should really only get the hostname if the user explicitly requests this.
>> 
>> @dholmes-ora , could you confirm whether what I'm saying is correct or not?
>> 
>> Also, we will be needing a man page update on this, which is separate to the usual PR process.
>> 
>> Thanks for doing this work!
>> Johan
>
>> We should really only get the hostname if the user explicitly requests this.
> 
> Yes I agree. The existing use of hostname in UL only comes into play if that decorator is requested; and error reporting only includes hostname in debug builds due to its sensitive nature.

@dholmes-ora
Is this PR approvable, or do you have more comments?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18153#issuecomment-2034352941