RFR: 8327410: Add hostname option for UL file names [v4]

David Holmes dholmes at openjdk.org
Wed Apr 3 22:24:02 UTC 2024


On Tue, 2 Apr 2024 12:57:20 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:

>> Added %hn as way to make the Unified Logging file name include the host name.
>> This is done in line with the already existing %p for pid, and %t for time stamp.
>> 
>> Also the %hn decorator is already used to prepend the host name to each log line. See: The [JDK-8148219](https://bugs.openjdk.org/browse/JDK-8148219).
>> 
>> Example: `java -Xlog:gc+init:file=frbr_%hn.%p.%t.log -version`
>> 
>> Tested tier1-tier5.
>
> Fredrik Bredberg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'master' into 8327410_add_hostname_option_to_ul_filename
>  - Merge branch 'master' into 8327410_add_hostname_option_to_ul_filename
>  - Updated man page java.1
>  - Update after review
>  - Update after review
>  - Get the hostname only if the user explicitly requests it
>  - 8327410: Add hostname option for UL file names

Sorry @fbredber this one dropped off my radar. Nothing further from me. Changes look good.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18153#pullrequestreview-1978191436


More information about the hotspot-runtime-dev mailing list