RFR: 8328630: Add logging when needed symbols in dll are missing. [v5]

[Robbin Ehn]

On Wed, 3 Apr 2024 11:50:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use global namespace
>
> src/hotspot/os/windows/os_windows.cpp line 1283:
> 
>> 1281: 
>> 1282: void* os::dll_lookup(void *lib, const char *name) {
>> 1283:   ::GetLastError(); // Clear old pending errors
> 
> There is nothing in the specification for `GetLastError` to indicate that it will clear the error itself. If you want to do this then you need to call `SetLastError(0)`.

You are correct, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18404#discussion_r1549632987