RFR: 8329651: TestLibGraal.java crashes with assert(_stack_base != nullptr)

David Holmes dholmes at openjdk.org
Fri Apr 5 00:32:13 UTC 2024


On Thu, 4 Apr 2024 09:02:03 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The first thing a new thread does is record its stack size and base. But it is made visible to the rest of the system prior to that. So  we have a risk of trying to print information for a thread that may never have actually executed yet. `Thread::print_on_error` should access the `_stack_base` and `_stack_size` fields directly, not through the accessors with the assert.
>> 
>> Testing:
>>  - tiers 1-3 (sanity)
>> 
>> Thanks
>
> Marked as reviewed by stefank (Reviewer).

Thanks for the reviews @stefank  and @dcubed-ojdk

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18615#issuecomment-2038496107


More information about the hotspot-runtime-dev mailing list