RFR: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved [v3]

Liming Liu duke at openjdk.org
Mon Apr 8 09:27:00 UTC 2024


On Mon, 8 Apr 2024 09:08:46 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Liming Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Disable UseMadvPopulateWrite when not supported
>
> src/hotspot/os/linux/os_linux.hpp line 103:
> 
>> 101:     *major = _release_major;
>> 102:     *minor = _release_minor;
>> 103:   }
> 
> Do we really wan this function now, or could this be just plain getters?:
> 
> static long kernel_release_major() {
>   return _kernel_release_major;
> }
> static long kernel_release_minor() {
>   return _kernel_release_minor;
> }

systemMemoryBarrier_linux.cpp uses this function. If the interface was change here, the patch would involve some unrelated things.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18592#discussion_r1555508275


More information about the hotspot-runtime-dev mailing list