RFR: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved [v5]

Liming Liu duke at openjdk.org
Wed Apr 10 06:24:13 UTC 2024


On Tue, 9 Apr 2024 12:25:39 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Liming Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Mis-removed the two lines
>
> src/hotspot/os/linux/os_linux.cpp line 4843:
> 
>> 4841:       (ret == 0 &&
>> 4842:        (sscanf(buffer.release, "%ld.%ld", &major, &minor) == 2) &&
>> 4843:        (major > 5 || (major == 5 && minor >= 14)) &&
> 
> Why isn't this using the `os::Linux::kernel_version()` function?

Just not get the idea. Previous discussions mentioned the problems of kernel_version, so I used an alternative method. Using kernel_version here is fine with me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18592#discussion_r1558907474


More information about the hotspot-runtime-dev mailing list