RFR: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved [v5]
Stefan Karlsson
stefank at openjdk.org
Wed Apr 10 07:16:10 UTC 2024
On Wed, 10 Apr 2024 06:21:06 GMT, Liming Liu <duke at openjdk.org> wrote:
>> src/hotspot/os/linux/os_linux.cpp line 4843:
>>
>>> 4841: (ret == 0 &&
>>> 4842: (sscanf(buffer.release, "%ld.%ld", &major, &minor) == 2) &&
>>> 4843: (major > 5 || (major == 5 && minor >= 14)) &&
>>
>> Why isn't this using the `os::Linux::kernel_version()` function?
>
> Just not get the idea. Previous discussions mentioned the problems of kernel_version, so I used an alternative method. Using kernel_version here is fine with me.
FYI: @jdksjolen is going to fix `kernel_version` with #18697.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18592#discussion_r1558961922
More information about the hotspot-runtime-dev
mailing list