RFR: 8329864: TestLibGraal.java still crashes with assert(_stack_base != nullptr)

Daniel D. Daugherty dcubed at openjdk.org
Sat Apr 13 13:55:41 UTC 2024


On Tue, 9 Apr 2024 04:05:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

> The changes to `JavaThread::print_on_error` were overlooked when `Thread::print_on_error` was fixed by https://github.com/openjdk/jdk/pull/18615. The fix is identical: access the `_stack_base` and `_stack_size` fields directly, not through the accessors with the assert.
> 
> Testing:
> - tiers 1-3 sanity
> 
> Thanks

Thumbs up.

Sorry for missing this on the review of https://github.com/openjdk/jdk/pull/18615

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18683#pullrequestreview-1999266869


More information about the hotspot-runtime-dev mailing list