RFR: 8329864: TestLibGraal.java still crashes with assert(_stack_base != nullptr)
David Holmes
dholmes at openjdk.org
Mon Apr 15 07:35:46 UTC 2024
On Sat, 13 Apr 2024 13:52:53 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> The changes to `JavaThread::print_on_error` were overlooked when `Thread::print_on_error` was fixed by https://github.com/openjdk/jdk/pull/18615. The fix is identical: access the `_stack_base` and `_stack_size` fields directly, not through the accessors with the assert.
>>
>> Testing:
>> - tiers 1-3 sanity
>>
>> Thanks
>
> Thumbs up.
>
> Sorry for missing this on the review of https://github.com/openjdk/jdk/pull/18615
Thanks for the reviews @dcubed-ojdk and @jdksjolen !
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18683#issuecomment-2055861314
More information about the hotspot-runtime-dev
mailing list