RFR: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion

Andrey Turbanov aturbanov at openjdk.org
Fri Aug 9 07:16:36 UTC 2024


On Thu, 8 Aug 2024 13:15:23 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> In method map_or_reserve_memory_aligned on Windows we should enhance the output in the remap assertion, to get more details in case of failures.

src/hotspot/os/windows/os_windows.cpp line 3465:

> 3463:   }
> 3464: 
> 3465:   assert(aligned_base != nullptr, "Did not manage to re-map after %d attempts?", max_attempts);

Shouldn't we remove previous assertion then?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20510#discussion_r1710912384


More information about the hotspot-runtime-dev mailing list