RFR: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion

Matthias Baesken mbaesken at openjdk.org
Fri Aug 9 07:21:36 UTC 2024


On Fri, 9 Aug 2024 07:14:02 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> In method map_or_reserve_memory_aligned on Windows we should enhance the output in the remap assertion, to get more details in case of failures.
>
> src/hotspot/os/windows/os_windows.cpp line 3465:
> 
>> 3463:   }
>> 3464: 
>> 3465:   assert(aligned_base != nullptr, "Did not manage to re-map after %d attempts?", max_attempts);
> 
> Shouldn't we remove previous assertion then?

Yes, my mistake.
Will  do this.
Thanks for looking into it!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20510#discussion_r1710924652


More information about the hotspot-runtime-dev mailing list