RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4]

Jan Kratochvil jkratochvil at openjdk.org
Fri Aug 30 07:17:20 UTC 2024


On Thu, 29 Aug 2024 06:11:00 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Set _path to nullptr (cgv1)
>
> src/hotspot/os/linux/cgroupUtil_linux.cpp line 146:
> 
>> 144:   os::free(orig);
>> 145:   return;
>> 146: }
> 
> The duplications are regrettable. We usually do these things with a Closure object, but that is hard to do here, among other things since the controller object itself is mutable.

FYI @tstuefe  [I did unify](https://github.com/openjdk/jdk/compare/82db527b74a3dc49ea7dc05632be806a6c193770...fc17369cfb080b525d45deec3a2956d704851a69.diff) that @jerboaa's code by a template but @jerboaa did not like it. ([My patch](https://openjdk.github.io/cr/?repo=jdk&pr=17198&range=11) had neither code duplications nor templates.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20646#discussion_r1738083192


More information about the hotspot-runtime-dev mailing list