RFR: 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected [v4]
Severin Gehwolf
sgehwolf at openjdk.org
Thu Aug 29 16:23:39 UTC 2024
On Thu, 29 Aug 2024 09:32:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> src/hotspot/os/linux/cgroupSubsystem_linux.hpp line 216:
>>
>>> 214: virtual void set_subsystem_path(const char* cgroup_path) = 0;
>>> 215: virtual char* mount_point() = 0;
>>> 216: virtual char* cgroup_path() = 0;
>>
>> Please return const char*. Nobody should modify the contents of these strings from the outside via their pointers.
>
> will do.
https://github.com/openjdk/jdk/pull/20646/commits/e29f29a9a8ac80e253204de32dd3c08b253ebc72 does that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20646#discussion_r1736633393
More information about the hotspot-runtime-dev
mailing list