RFR: 8345635: JVMCI compiler should not be disabled by java -Xshare:dump [v2]

[Ioi Lam]

On Wed, 11 Dec 2024 21:32:55 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Need to check for EnableJVMCI as well
>>  - Need to check for EnableJVMCIProduct as well
>
> src/hotspot/share/cds/cdsConfig.cpp line 432:
> 
>> 430: 
>> 431:   if (is_dumping_static_archive()) {
>> 432:     if (!mode_flag_cmd_line JVMCI_ONLY(&& !UseJVMCICompiler && !UseGraalJIT && !EnableJVMCIProduct && !EnableJVMCI)) {
> 
> I would suggest expanding the comment to explain why so many JVMCI flags need to be checked here.

I added the following comments


// We check the JVMCI flags here to avoid running with -Xint when the JVMCI compiler is used.
// Ideally we should only check EnableJVMCI, but that flag can be ergonomically enabled
// in CompilerConfig::check_args_consistency(), which is called after the current function returns.
// So we have to manually check all the relevant flags here. TODO: This should be refactored.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22687#discussion_r1881118568