RFR: 8346159: Disable CDS AOTClassLinking tests for JVMCI due to JDK-8345635 [v2]
Ioi Lam
iklam at openjdk.org
Fri Dec 13 17:59:51 UTC 2024
On Fri, 13 Dec 2024 08:56:58 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> @dougxc review -- added "@comment work around JDK-8345635"
>
> test/hotspot/jtreg/runtime/cds/appcds/LambdaWithUseImplMethodHandle.java line 31:
>
>> 29: * @requires vm.cds
>> 30: * @requires vm.cds.supports.aot.class.linking
>> 31: * @requires !vm.jvmci.enabled
>
> Can `@requires` lines have comments? It wouldn't hurt to call out that this is a workaround pending resolution of [JDK-8345969](https://bugs.openjdk.org/browse/JDK-8345969) (or some other issue).
I added comments as you suggested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22730#discussion_r1884295109
More information about the hotspot-runtime-dev
mailing list