RFR: 8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob

Fei Yang fyang at openjdk.org
Tue Dec 17 00:04:42 UTC 2024


On Sat, 14 Dec 2024 08:44:09 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Hi, please review this small change fixing several typos in assertion code.
>> 
>> I find that the verification of encoding of the poll instruction in this blob is not correct.
>> The code loads the instruction and checks for three bit fields, but it uses wrong masks. This
>> won't trigger an assertion failure as the masks used are the same as the expected values.
>> 
>> Testing on linux-riscv64 platform:
>> - [x] hotspot:tier1 (fastdebug)
>
> Nice catch!

@feilongjiang @robehn : Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22750#issuecomment-2547184127


More information about the hotspot-runtime-dev mailing list