RFR: 8346866: [ASAN] memoryReserver.cpp reported applying non-zero offset to non-null pointer produced null pointer [v2]

[SendaoYan]

On Tue, 31 Dec 2024 08:10:02 GMT, SendaoYan <syan at openjdk.org> wrote:

>> The proposed change is not correct.  Consider if attach_point, lowest_start,
>> and stepsize are all equal.  In such a case this would stop without trying
>> that case, even though it should try it.  Changing the comparison with
>> stepsize to >= would fix that.  But it still wouldn't be correct.  Consider if
>> attach_point == lowest_start and stepsize > lowest_start.  That should also be
>> tried.
>
> Sorry, I need more investigate.

1. The `attach_point <= highest_start` has been removed.
2. Add `attach_point <= stepsize` check at the end of for loop, to make sanitizer silent and avoid warp around. The added check seems a bit deliberately but useful.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22897#discussion_r1900016585