RFR: 8313306: More sensible reservation logging [v10]

[Coleen Phillimore]

On Tue, 13 Feb 2024 19:48:31 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> This PR implements more specialized logs for virtual memory APIs in the “os” namespace. It uses “os” and “map” as log tags using unified JVM logging as introduced in JEP 158 (https://openjdk.org/jeps/158). 
>> 
>> As far as testing is concerned, I have added a regression test to verify the logging is working accordingly.
>
> Sonia Zaldana Calles has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Breaking long lines
>  - Fixing indentation, lacking commas, removing casting and replacing call with fatal

This looks reasonable with some suggestions.  Thanks.

src/hotspot/os/aix/os_aix.cpp line 1506:

> 1504:                          RANGEFMTARGS(p, s),
> 1505:                          (unsigned long)pagesize);
> 1506:       guarantee0(false);

I think the same thing can be done here - move the message into the fatal message.  Why does AIX have this?

#define assert0(b) assert((b), "")
#define guarantee0(b) guarantee((b), "")

??

src/hotspot/os/aix/os_aix.cpp line 1615:

> 1613:                        os::strerror(ep.saved_errno()));
> 1614:     // I want to know if this ever happens.
> 1615:     assert(false, "failed to set page size for shmat");

All of these messages could be printed with fatal() rather than assert(false) ?  Unless it's against some AIX policy?

-------------

Changes requested by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17356#pullrequestreview-1879117538
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1488709448
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1488711154