RFR: 8313306: More sensible reservation logging [v10]

[David Holmes]

On Tue, 13 Feb 2024 23:21:51 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Breaking long lines
>>  - Fixing indentation, lacking commas, removing casting and replacing call with fatal
>
> src/hotspot/os/aix/os_aix.cpp line 1615:
> 
>> 1613:                        os::strerror(ep.saved_errno()));
>> 1614:     // I want to know if this ever happens.
>> 1615:     assert(false, "failed to set page size for shmat");
> 
> All of these messages could be printed with fatal() rather than assert(false) ?  Unless it's against some AIX policy?

assert will only fire on debug builds whereas fatal will fire on all builds. I assume the intent is to catch this during testing but only log in production ??

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1488912258