RFR: 8313306: More sensible reservation logging [v10]

[Thomas Stuefe]

On Tue, 13 Feb 2024 23:19:06 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Breaking long lines
>>  - Fixing indentation, lacking commas, removing casting and replacing call with fatal
>
> src/hotspot/os/aix/os_aix.cpp line 1506:
> 
>> 1504:                          RANGEFMTARGS(p, s),
>> 1505:                          (unsigned long)pagesize);
>> 1506:       guarantee0(false);
> 
> I think the same thing can be done here - move the message into the fatal message.  Why does AIX have this?
> 
> #define assert0(b) assert((b), "")
> #define guarantee0(b) guarantee((b), "")
> 
> ??

+1 to fatal().

>Why does AIX have this?
>
>#define assert0(b) assert((b), "")
>#define guarantee0(b) guarantee((b), "")
>
>??

This is my code I think, from way back when we started the AIX port at SAP. Based on Suns licensed hotspot sources. I really disliked having to state a reason for the assert every time I wrote one, so I saved me work by adding the 0 variants. I kind of came to terms with the reason parameter now.

Note that was from a time where we could not give back coding upstream, so the AIX port has a number of constructs like this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1488967732