RFR: 8313306: More sensible reservation logging [v10]

Thomas Stuefe stuefe at openjdk.org
Wed Feb 14 06:53:06 UTC 2024


On Wed, 14 Feb 2024 05:35:55 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Breaking long lines
>>  - Fixing indentation, lacking commas, removing casting and replacing call with fatal
>
> src/hotspot/os/aix/os_aix.cpp line 1498:
> 
>> 1496:   void assert_is_valid_subrange(char* p, size_t s) const {
>> 1497:     if (!contains_range(p, s)) {
>> 1498:       fatal(os,map)(RANGEFMT " is not a sub "
> 
> `fatal` is not part of UL.

Yes. Use fatal like this: 

fatal("format string", ...);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1488988468


More information about the hotspot-runtime-dev mailing list