RFR: 8313306: More sensible reservation logging [v10]
David Holmes
dholmes at openjdk.org
Wed Feb 14 05:41:03 UTC 2024
On Tue, 13 Feb 2024 19:48:31 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:
>> This PR implements more specialized logs for virtual memory APIs in the “os” namespace. It uses “os” and “map” as log tags using unified JVM logging as introduced in JEP 158 (https://openjdk.org/jeps/158).
>>
>> As far as testing is concerned, I have added a regression test to verify the logging is working accordingly.
>
> Sonia Zaldana Calles has updated the pull request incrementally with two additional commits since the last revision:
>
> - Breaking long lines
> - Fixing indentation, lacking commas, removing casting and replacing call with fatal
Changes requested by dholmes (Reviewer).
src/hotspot/os/aix/os_aix.cpp line 1498:
> 1496: void assert_is_valid_subrange(char* p, size_t s) const {
> 1497: if (!contains_range(p, s)) {
> 1498: fatal(os,map)(RANGEFMT " is not a sub "
`fatal` is not part of UL.
-------------
PR Review: https://git.openjdk.org/jdk/pull/17356#pullrequestreview-1879395443
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1488906997
More information about the hotspot-runtime-dev
mailing list