RFR: 8313306: More sensible reservation logging [v11]

[Coleen Phillimore]

On Wed, 14 Feb 2024 15:31:20 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> This PR implements more specialized logs for virtual memory APIs in the “os” namespace. It uses “os” and “map” as log tags using unified JVM logging as introduced in JEP 158 (https://openjdk.org/jeps/158). 
>> 
>> As far as testing is concerned, I have added a regression test to verify the logging is working accordingly.
>
> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing lingering UL params I missed on fatal call and adding one more fatal call

I have a couple of suggestions but it  looks good to me.

src/hotspot/share/runtime/os.hpp line 171:

> 169:   int saved_errno() {
> 170:     return _e;
> 171:   }

You could also make these functions one lines to save vertical white space, since they're short lines.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17356#pullrequestreview-1880818041
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1489804920