RFR: 8322657: CDS filemap fastdebug assert while loading Graal CE Polyglot in isolated classloader

[Matias Saavedra Silva]

On Fri, 5 Jan 2024 05:08:23 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Please review this small fix for skipping the non-existent `SharedClassPathEntry` in `FileMapInfo::get_module_shared_path_index`.
> Please refer to the bug report for more details.
> 
> Passed tiers 1 - 4 testing, including the new test.

Looks good! If you think it's worth addressing I just have one comment.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/test-classes/DefineModuleApp.java line 39:

> 37:     public static void main(String[] args) throws Throwable {
> 38:         if (args.length != 2) {
> 39:             throw new RuntimeException("DefineModuleApp expects 2 args but saw only " + args.length);

Minor nit: "only" is probably unnecessary in the exception message since you could technically pass more than 2 args.

-------------

Marked as reviewed by matsaave (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17275#pullrequestreview-1810109991
PR Review Comment: https://git.openjdk.org/jdk/pull/17275#discussion_r1445401941