RFR: 8314186: runtime/8176717/TestInheritFD.java failed with "Log file was leaked" [v2]

Leo Korinth lkorinth at openjdk.org
Wed Jan 10 15:02:26 UTC 2024


On Wed, 10 Jan 2024 14:45:52 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> This PR intends to make the test a bit more sturdy by looking for both the success string and the failure string, reporting that the test messed up if neither are found. I also removed the extra newline at the end of the file and did some special reporting in case of a `TimeoutException`.
>> 
>> Thanks!
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change messages etc

`import java.util.concurrent.TimeoutException;` can be removed now I think. Otherwise I think it looks good, thanks for improving the test case.

test/hotspot/jtreg/runtime/8176717/TestInheritFD.java line 44:

> 42: import java.io.InputStreamReader;
> 43: import java.util.Collection;
> 44: import java.util.concurrent.TimeoutException;

`import java.util.concurrent.TimeoutException; ` can be removed now I think. Otherwise I think it looks good, thanks for improving the test case.

-------------

Marked as reviewed by lkorinth (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17325#pullrequestreview-1813423742
PR Review Comment: https://git.openjdk.org/jdk/pull/17325#discussion_r1447501947


More information about the hotspot-runtime-dev mailing list