RFR: 8314186: runtime/8176717/TestInheritFD.java failed with "Log file was leaked" [v2]

Johan Sjölen jsjolen at openjdk.org
Fri Jan 19 10:54:40 UTC 2024


On Wed, 10 Jan 2024 14:58:01 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change messages etc
>
> test/hotspot/jtreg/runtime/8176717/TestInheritFD.java line 44:
> 
>> 42: import java.io.InputStreamReader;
>> 43: import java.util.Collection;
>> 44: import java.util.concurrent.TimeoutException;
> 
> `import java.util.concurrent.TimeoutException; ` can be removed now I think. Otherwise I think it looks good, thanks for improving the test case.

I decided to check the cause of the `CompletionException` using instanceof, so the import is needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17325#discussion_r1458780926


More information about the hotspot-runtime-dev mailing list