RFR: 8323438: Enhance assertions for Windows sync API failures

[David Holmes]

Using the assertion pattern employed in windows_semaphore.cpp, the other (inadequately checked) calls to WaitForSingleObject are checked more thoroughly so that the actual failure mode is reported.

The only tricky part of these changes is a change to the if/else control flow so that the result of the call can be checked, in one section. Otherwise we just expand existing assertions or guarantees.

Testing: Windows tiers 1-4 sanity

Thanks

-------------

Commit messages:
 - 8323438: Enhance assertions for Windows sync API failures

Changes: https://git.openjdk.org/jdk/pull/17457/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17457&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8323438
  Stats: 33 lines in 3 files changed: 21 ins; 1 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/17457.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17457/head:pull/17457

PR: https://git.openjdk.org/jdk/pull/17457