RFR: 8323576: [Windows] Fallthrough to ::abort instead of os::infinite_sleep for noreturn methods [v2]

[Julian Waters]

On Thu, 18 Jan 2024 07:54:09 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - std::abort to ::abort in vmError_windows.cpp
>>  - std::_Exit to ::_Exit in os_windows.cpp
>
> src/hotspot/os/windows/os_windows.cpp line 4238:
> 
>> 4236:     ALLOW_C_FUNCTION(::exit, ::exit(exit_code);)
>> 4237:   } else { // EPT_PROCESS_DIE
>> 4238:     ::_Exit(exit_code);
> 
> I don't see any reason to change this line.

Ah, I was thinking the standard C method could be preferred over the Microsoft deprecated _exit method, but I guess that's out of scope. I'm currently working on some build dev issue, I'll change this back later on

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17366#discussion_r1457481245